Tests: Do not assume empty vectors alias #158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, TS uses Base.mightalias to throw an error if the two inputs to three- arg transcode alias.
Two problems here: Base.mightalias is internal, and the new memory PR to Julia changes aliasing of zero-length arrays.
The temporary fix for now is to remove the test that tests that zero-length arrays trips the Base.mightalias. Later, let's fix this properly by not relying on Base internals in TS tests.
This fixes TranscodingStreams' test errors on JuliaLang/julia#51319