-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests to be agnostic to type printing #183
Conversation
JuliaLang/julia#37085 changed how type parameters are printed, causing the following error: ``` Borders (issue JuliaImages#85): Test Failed at /home/runner/work/ImageFiltering.jl/ImageFiltering.jl/test/2d.jl:337 Expression: imfilter(A, kern, Fill(0, (3,))) Expected: ArgumentError("Fill{Int64,1}(0, (3,), (3,)) lacks the proper padding sizes for an array with 2 dimensions") Thrown: ArgumentError("Fill{Int64, 1}(0, (3,), (3,)) lacks the proper padding sizes for an array with 2 dimensions") ```
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
=======================================
Coverage 77.60% 77.60%
=======================================
Files 9 9
Lines 978 978
=======================================
Hits 759 759
Misses 219 219 Continue to review full report at Codecov.
|
Let's first check if it is stilling working wrt #182 |
Did closing and opening trigger the CI? I wasn't sure why it didn't run to begin with. |
I disabled the fail-fast option 1172657 so that even if there's a test failure in nightly build, others are still running; a close and reopen would build the CI in the new master base. |
A similar ambiguity issue is found in JuliaArrays/OffsetArrays.jl#139 I'll go check it first this weekend and then revisit this PR. |
The ambiguity issue might be changed or reverted; see JuliaLang/julia#36962 (comment). I'm sitting pat for a while in my other repos, or just transiently disabling the ambiguity test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnnychen94, if this looks good to you please merge.
JuliaLang/julia#37085 changed how type parameters
are printed, causing the following error:
See https://github.com/JuliaImages/ImageFiltering.jl/runs/1053929388?check_suite_focus=true#step:5:273 for the CI failure.