Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML support for showing images #49

Closed
wants to merge 2 commits into from

Conversation

lorenzoh
Copy link
Contributor

Closes #48.

Just the basic version discussed.

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #49 (b3023b4) into master (324e8a4) will increase coverage by 0.61%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   87.89%   88.51%   +0.61%     
==========================================
  Files           6        6              
  Lines         223      235      +12     
==========================================
+ Hits          196      208      +12     
  Misses         27       27              
Impacted Files Coverage Δ
src/ImageShow.jl 0.00% <ø> (ø)
src/showmime.jl 96.73% <100.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 324e8a4...b3023b4. Read the comment docs.

@lorenzoh
Copy link
Contributor Author

Not really sure what goes wrong on CI 1.0. Any idea?

src/showmime.jl Outdated Show resolved Hide resolved
@johnnychen94
Copy link
Member

Not really sure what goes wrong on CI 1.0. Any idea?

I'll check it tomorrow. If there isn't a simple fix then it's time to bump the Julia lower bound to 1.3; maintaining 1.0 is becoming less and less necessary nowadays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output embeddable HTML directly
2 participants