Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing fixes #394

Merged
merged 4 commits into from
Nov 3, 2015
Merged

Testing fixes #394

merged 4 commits into from
Nov 3, 2015

Conversation

timholy
Copy link
Member

@timholy timholy commented Nov 3, 2015

Fixes an occasional fail-to-fail issue (e.g., https://ci.appveyor.com/project/timholy/images-jl/build/1.0.424/job/kinjj8svl0dxf3gp, JuliaLang/julia#13834 (comment)). CC @tkelman. Also tests that #356 really is fixed now thanks to #393. CC @cdsousa, @mbauman.

@timholy
Test type-stability of similar
7942a4e 
Tests that the fix in #393 covers #356
@timholy
Copy link
Member Author

timholy commented Nov 3, 2015

https://travis-ci.org/timholy/Images.jl/jobs/88983419 finally captured the infamous off-by-one bug. Remarkably, it seems due to a difference between x/s and x*(1/s). Hopefully fixed in the 3rd commit in this PR. CC @SimonDanisch.

@timholy
Reduce spurious fail-to-fail errors with test_approx_eq_sigma_eps
77dfa16 
Sometimes a blurred rand(5,5) will happen to match a different blurred
rand(5,5). This should be less likely for larger arrays, and with
higher stringency.
@timholy
Loosen one test due to rounding issues & order of floating-point oper…
e7d627b 
…ations
@timholy
Whitespace changes.
531e3ce
timholy added a commit that referenced this pull request Nov 3, 2015
@timholy
Merge pull request #394 from timholy/teh/testing_fixes
814a3d6 
Testing fixes
@timholy timholy merged commit 814a3d6 into master Nov 3, 2015
@timholy timholy deleted the teh/testing_fixes branch November 3, 2015 13:34
@timholy
Copy link
Member Author

timholy commented Nov 3, 2015

@tkelman, since I'm looking at the tests carefully: I noticed that the 64-bit AppVeyor tests take much longer than the 32-bit, see https://ci.appveyor.com/project/timholy/images-jl/build/1.0.430. After the installation of julia itself, one step that seems to take a long time (3-5 minutes) is going from INFO: Testing Images to seeing any kind of output for the first test. On 32-bit it's not speedy either, but it's more like 1 minute. I'm guessing it's precompiling during that time, but the performance difference might be a source of concern?

@tkelman
Copy link
Collaborator

tkelman commented Nov 4, 2015

Yes it might, but I don't think I'm equipped in either time or skill to get to the bottom of that one particularly soon.

@timholy timholy mentioned this pull request Nov 17, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timholy @tkelman