-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LLVM install using Homebrew.jl on macOS #188
Conversation
`prefix` does not exist. This approach works because the Julia Homebrew tree is put on the path after `using Homebrew`.
I'm not sure what happened with the Travis changes. Adding Macs seemed to work over here: |
The llvm brew is keg-only, meaning that llvm-config is not added to the $PATH. Point right at it instead.
@@ -51,7 +51,8 @@ function find_llvm() | |||
Homebrew.add("llvm") | |||
end | |||
end) | |||
if (lcf = isfile(joinpath(prefix, "llvm-config"))) | |||
if (lcf = isfile(joinpath(Homebrew.prefix(), | |||
"deps/opt/llvm/llvm-config"))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the path has been changed again, this works on my machine:
lcf = joinpath(Homebrew.prefix(), "Cellar/llvm/6.0.0/bin/llvm-config")
isfile(lcf) && return lcf
@ihnorton What parts of clang do you need Elliot and I are working on getting LLVM and Clang building with BinaryProvider (see https://github.com/staticfloat/LLVMBuilder) and we aim to provide Clang. |
Just libclang.so/dylib (C API). Are you envisioning support for Cxx.jl too? Some things I've done in the past (and may try to do again) needed a few hooks in to the C++ API for functionality not exposed through libclang -- but much less of the API than Cxx.jl needs. |
closed in favor of #216 |
No description provided.