Fixes for compatibility with v0.7.0-alpha.0 #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musm
reviewed
Jun 12, 2018
src/MATLAB.jl
Outdated
| Base.depwarn("MATLAB.nfields is deprecated, use mxnfields instead.", :nfields) | ||
| return mxfields(mx) | ||
| end | ||
|
|
||
| @deprecate jvariable jvalue | ||
|
|
||
| function jvariable(mx::MxArray, ty::Type{AbstractString}) | ||
| Base.depwarn("jvariable(mx::MxArray,ty::Type{AbstractString}) is |
There was a problem hiding this comment.
please add back spaces to the depwarn
musm
reviewed
Jun 12, 2018
src/mxarray.jl
Outdated
| @@ -68,7 +68,7 @@ const mxCELL_CLASS = convert(mxClassID, 1) | |||
| const mxSTRUCT_CLASS = convert(mxClassID, 2) | |||
| const mxLOGICAL_CLASS = convert(mxClassID, 3) | |||
| const mxCHAR_CLASS = convert(mxClassID, 4) | |||
| const mxVOID_CLASS = convert(mxClassID, 5) | |||
| const mxCvoid_CLASS = convert(mxClassID, 5) | |||
|
thanks! |
musm
approved these changes
Jun 12, 2018
|
I've fixed the comments from the code review - hopefully all good to go now! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings compatibility with v0.7.0-alpha.0 while also maintaining compatibility with v0.6. Most of the changes are simple deprecation fixes.
A few points to note:
x[1:3]) I've added:(:)to the MATLAB infix operators. As such,mstatementdoesn't produce such nice output as before but it works without special casing. (For examplemstatement(:(x[1:3])) == "x((1) : (3))"rather than"x(1:3)"as before.)mat"$(x[1:3]) = 3"); in this case v0.7 requires that a broadcasted assignment is used explicitly.Tests pass (on my machine at least) with v0.6.2 and v0.7.0-alpha.0.