Break up long testsets #247

cpierard · 2017-03-07T20:52:05Z

Break chunks of code that are longer than 100 lines in the file libieeep1788_tests_elem.jl.

coveralls · 2017-03-07T21:02:41Z

Coverage remained the same at 91.284% when pulling 06cbf1d on cpierard:rama_trabajo into c7a230a on dpsanders:master.

codecov-io · 2017-03-07T21:05:41Z

Codecov Report

Merging #247 into master will increase coverage by 0.78%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
+ Coverage   91.28%   92.06%   +0.78%     
==========================================
  Files          26       26              
  Lines        1044     1084      +40     
==========================================
+ Hits          953      998      +45     
+ Misses         91       86       -5

Impacted Files	Coverage Δ
src/intervals/rounding.jl	`71.79% <0%> (-4.68%)`	⬇️
src/intervals/precision.jl	`88.46% <0%> (-1.2%)`	⬇️
src/display.jl	`93.18% <0%> (-0.16%)`	⬇️
src/intervals/functions.jl	`95.74% <0%> (ø)`	⬆️
src/root_finding/newton.jl	`91.22% <0%> (ø)`	⬆️
src/root_finding/bisect.jl	`100% <0%> (ø)`	⬆️
src/ValidatedNumerics.jl	`100% <0%> (ø)`	⬆️
src/intervals/arithmetic.jl	`100% <0%> (+1.35%)`	⬆️
src/multidim/intervalbox.jl	`86.66% <0%> (+2.05%)`	⬆️
src/decorations/intervals.jl	`84.61% <0%> (+2.56%)`	⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7a230a...cee7623. Read the comment docs.

dpsanders · 2017-03-08T00:29:33Z

Thanks! Did you do this by hand or in an automated way?

cpierard · 2017-03-08T00:46:05Z

I did it by hand. I tried doing it in an automated way, but I failed.

dpsanders · 2017-03-08T11:44:36Z

These files are automatically generated, so the next time they are regenerated all of your work will be lost. That's why this should be done in an automated way.

What did you try?

cpierard · 2017-03-08T15:32:11Z

Didn't know that. This is what I did so far:

f = open("libieeep1788_tests_elem.jl")
code_lines = readlines(f)

#println(code_lines[70][1:5])
#println(length(code_lines))

A = Int[]

chunk_begin = 0
chunk_end = 0

for i in 1:length(code_lines)

  if length(code_lines[i]) <= 3

    nothing

  elseif code_lines[i][1:3] == "fac"

    chunk_begin = i
    #println(chunk_begin)

  elseif code_lines[i][1:3] == "end"

    chunk_end = i
    #println(chunk_end)

  end

  if chunk_end - chunk_begin > 100

    push!(A, chunk_begin)
    chunk_end = 0

  end

end

println(A)

This code looks for the big blocks of code bigger than 100. My idea was to break-up the blocks in smaller ones by inserting facts(... ) do and end between the big blocks in the array that contains all the lines of code.

Do you have any suggestions?

dpsanders · 2017-03-12T07:54:52Z

That looks like a good start.
You can use the startswith function to look at the start of a line.

I suggest you just accumulate the lines in each facts block into an array, and then write them out in blocks of 100 in new facts blocks.

dpsanders · 2017-03-12T07:55:33Z

(Of course, 100 should be a variable that can be changed.)

coveralls · 2017-03-15T17:58:09Z

Coverage increased (+0.02%) to 91.309% when pulling 6aca91c on cpierard:rama_trabajo into c7a230a on dpsanders:master.

…ith test_file.jl

dpsanders · 2017-03-15T20:24:08Z

This is looking nice!

I suggest making this into a function which takes in a file name and chunk size as arguments.

coveralls · 2017-03-15T22:24:44Z

Coverage increased (+0.05%) to 91.333% when pulling 9419559 on cpierard:rama_trabajo into c7a230a on dpsanders:master.

cpierard · 2017-03-15T22:37:28Z

Ok, I will wrap it in a function once is working well. What did you mean by expressions? Can you read an entire file as an expression (or an array of expressions)?

dpsanders · 2017-03-15T22:41:07Z

I meant "regular expression" -- it's a way to specify a pattern to match and to capture the result of matching that pattern:

https://en.wikipedia.org/wiki/Regular_expression

https://en.wikibooks.org/wiki/Introducing_Julia/Strings_and_characters#Regular_expressions

cpierard · 2017-03-15T22:48:48Z

thanks! It's just what I was looking for this morning. It will make the code look cleaner.

coveralls · 2017-03-16T01:09:50Z

Coverage increased (+0.05%) to 91.333% when pulling 0afc242 on cpierard:rama_trabajo into c7a230a on dpsanders:master.

lbenet · 2017-03-16T14:40:23Z

Would it be possible to get rid of a bunch of empty lines in test/ITF1788_tests/test_file.jl ?

cpierard · 2017-03-18T05:27:04Z

@lbenet Yes, it was a problem with the delimiter in the instruction join(code_lines_new, "\n"). Now is writing the file without empty lines.

coveralls · 2017-03-18T05:47:00Z

Coverage decreased (-1.01%) to 90.269% when pulling 871b973 on cpierard:rama_trabajo into c7a230a on dpsanders:master.

coveralls · 2017-03-18T05:53:58Z

Coverage decreased (-1.01%) to 90.269% when pulling 871b973 on cpierard:rama_trabajo into c7a230a on dpsanders:master.

coveralls · 2017-03-18T05:53:59Z

Coverage decreased (-1.01%) to 90.269% when pulling 871b973 on cpierard:rama_trabajo into c7a230a on dpsanders:master.

coveralls · 2017-03-18T06:25:43Z

Coverage decreased (-1.01%) to 90.269% when pulling d87213b on cpierard:rama_trabajo into c7a230a on dpsanders:master.

coveralls · 2017-03-18T06:25:43Z

Coverage decreased (-1.01%) to 90.269% when pulling d87213b on cpierard:rama_trabajo into c7a230a on dpsanders:master.

cpierard · 2017-03-19T07:23:58Z

I think the function is finished . I was comparing the test_file.jl with the original file, and it seems that all the lines of code are in the test file. Maybe the name for the function is not the best...

coveralls · 2017-03-19T07:37:30Z

Coverage decreased (-1.01%) to 90.269% when pulling 51af0f4 on cpierard:rama_trabajo into c7a230a on dpsanders:master.

dpsanders · 2017-03-19T13:36:35Z

Thanks, it's looking good!
So in the end you didn't use regular expressions?

Maybe a better name is something like split_testsets (for the function and the filename).

Could you write a test for this? I suggest using a simple test file like the one here: JuliaLang/julia#15346

The next step would be to make a new file that runs through each of the test files in the directory and splits them with a sensible name, maybe as they are being run.

I wonder if it would even be sensible to make this into a separate package, though that can be done later.

cpierard · 2017-03-21T05:23:23Z

I didn't include my attempts to use regex because they were not working. So far I found the expression to match the title for each block:

match(r"\".*\"", code_lines[chunk_begin]).match

But returns "\"minimal_pos_test\"", and I have to get rid of the extras ".

I found two solutions:

title = parse(match(r"\".*\"", code_lines[chunk_begin]).match)

or

title = split(match(r"\".*\"", code_lines[chunk_begin]).match, "\"")[2].

Ok, I will start writing the test for this.

coveralls · 2017-03-21T05:52:41Z

Coverage increased (+0.8%) to 92.066% when pulling cee7623 on cpierard:rama_trabajo into c7a230a on dpsanders:master.

dpsanders · 2019-03-02T19:11:26Z

In the latest versions of Julia, the tests run much faster, so this is probably no longer necessary.

cpierard added 2 commits March 6, 2017 23:35

Break up long suits lines 0 - 3357

2c64230

Finish breaking up the big chunks

06cbf1d

Failed to find a function to search for word in line

fdb4f56

Improve code. Can find the big blocks

8d1c33f

dpsanders changed the title ~~Break up big suits of code~~ Break up big test suites Mar 12, 2017

cpierard added 3 commits March 13, 2017 22:43

cambio de rama para reescribir código

2c55b3b

Avances despues consejos David

bdd334e

Merge branch 'aut_1' into rama_trabajo

6aca91c

Start separating big blocks of code in small ones and do some tests w…

9419559

…ith test_file.jl

Restore original libieeep1788_test_elem.jl file

0afc242

Add the residue blocks and change delimiters

25b3a19

changing delimiters

871b973

cpierard added 2 commits March 18, 2017 00:03

comment the code, run separatebigchunk.jl for all the the file

d87213b

Wrap separatebigchunks.jl code in a function

1ee4ae7

Wrap code in fnction separate_chunks()

51af0f4

dpsanders changed the title ~~Break up big test suites~~ Break up long testsets Mar 19, 2017

cpierard added 2 commits March 20, 2017 23:29

Include Regex and rename function

36cc993

Rename file

cee7623

ignacio-vc mentioned this pull request Sep 21, 2018

🛣️ The long and treacherous road to compliance with the ITF1788 test suite JuliaIntervals/IntervalArithmetic.jl#225

Closed

dpsanders closed this Mar 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Break up long testsets #247

Break up long testsets #247

cpierard commented Mar 7, 2017 •

edited by dpsanders

Loading

coveralls commented Mar 7, 2017

codecov-io commented Mar 7, 2017 •

edited

Loading

dpsanders commented Mar 8, 2017

cpierard commented Mar 8, 2017

dpsanders commented Mar 8, 2017

cpierard commented Mar 8, 2017

dpsanders commented Mar 12, 2017

dpsanders commented Mar 12, 2017

coveralls commented Mar 15, 2017 •

edited

Loading

dpsanders commented Mar 15, 2017

coveralls commented Mar 15, 2017

cpierard commented Mar 15, 2017

dpsanders commented Mar 15, 2017

cpierard commented Mar 15, 2017

coveralls commented Mar 16, 2017

lbenet commented Mar 16, 2017

cpierard commented Mar 18, 2017 •

edited

Loading

coveralls commented Mar 18, 2017 •

edited

Loading

coveralls commented Mar 18, 2017

coveralls commented Mar 18, 2017

coveralls commented Mar 18, 2017

coveralls commented Mar 18, 2017

cpierard commented Mar 19, 2017

coveralls commented Mar 19, 2017 •

edited

Loading

dpsanders commented Mar 19, 2017

cpierard commented Mar 21, 2017

coveralls commented Mar 21, 2017 •

edited

Loading

dpsanders commented Mar 2, 2019

Break up long testsets #247

Break up long testsets #247

Conversation

cpierard commented Mar 7, 2017 • edited by dpsanders Loading

coveralls commented Mar 7, 2017

codecov-io commented Mar 7, 2017 • edited Loading

Codecov Report

dpsanders commented Mar 8, 2017

cpierard commented Mar 8, 2017

dpsanders commented Mar 8, 2017

cpierard commented Mar 8, 2017

dpsanders commented Mar 12, 2017

dpsanders commented Mar 12, 2017

coveralls commented Mar 15, 2017 • edited Loading

dpsanders commented Mar 15, 2017

coveralls commented Mar 15, 2017

cpierard commented Mar 15, 2017

dpsanders commented Mar 15, 2017

cpierard commented Mar 15, 2017

coveralls commented Mar 16, 2017

lbenet commented Mar 16, 2017

cpierard commented Mar 18, 2017 • edited Loading

coveralls commented Mar 18, 2017 • edited Loading

coveralls commented Mar 18, 2017

coveralls commented Mar 18, 2017

coveralls commented Mar 18, 2017

coveralls commented Mar 18, 2017

cpierard commented Mar 19, 2017

coveralls commented Mar 19, 2017 • edited Loading

dpsanders commented Mar 19, 2017

cpierard commented Mar 21, 2017

coveralls commented Mar 21, 2017 • edited Loading

dpsanders commented Mar 2, 2019

cpierard commented Mar 7, 2017 •

edited by dpsanders

Loading

codecov-io commented Mar 7, 2017 •

edited

Loading

coveralls commented Mar 15, 2017 •

edited

Loading

cpierard commented Mar 18, 2017 •

edited

Loading

coveralls commented Mar 18, 2017 •

edited

Loading

coveralls commented Mar 19, 2017 •

edited

Loading

coveralls commented Mar 21, 2017 •

edited

Loading