Skip to content

Commit

Permalink
Drop compat code for repr and showable from #497
Browse files Browse the repository at this point in the history
  • Loading branch information
martinholters committed Oct 8, 2019
1 parent e7ff254 commit cfa046e
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 14 deletions.
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,6 @@ Currently, the `@compat` macro supports the following syntaxes:

## Renaming

* `reprmime(mime, x)` is now `repr(mime, x)` ([#25990]) and `mimewritable` is now `showable` ([#26089]).

* `Compat.indexin` accepts any iterable as first argument, returns `nothing` (rather than `0`)
for entries with no match and gives the index of the first (rather than the last) match
([#25662], [#25998]).
Expand Down
9 changes: 0 additions & 9 deletions src/Compat.jl
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,6 @@ end
end
end

@static if VERSION < v"0.7.0-DEV.4047" #26089
showable(mime, x) = mimewritable(mime, x)
export showable
end

@static if VERSION < v"0.7.0-DEV.4010" #25990
Base.repr(mime::Union{AbstractString,MIME}, x) = reprmime(mime, x)
end

# https://github.com/JuliaLang/julia/pull/25647
@static if VERSION < v"0.7.0-DEV.3526"
names(m; all=false, imported=false) = Base.names(m, all, imported)
Expand Down
3 changes: 3 additions & 0 deletions test/old.jl
Original file line number Diff line number Diff line change
Expand Up @@ -773,3 +773,6 @@ end

@test findall([true, false, true]) == [1, 3]
@test findall(in([1, 2]), [1]) == [1]

@test repr("text/plain", "string") == "\"string\"" #25990
@test showable("text/plain", 3.14159) #26089
3 changes: 0 additions & 3 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,6 @@ module TestUUIDs
@test uuid4() isa UUID
end

@test repr("text/plain", "string") == "\"string\"" #25990
@test showable("text/plain", 3.14159) #26089

# 0.7.0-DEV.3526
module TestNames
export foo
Expand Down

0 comments on commit cfa046e

Please sign in to comment.