Support RangeGeneratorInt rename #440
Conversation
|
Good to merge? |
|
Needs an entry in the README |
src/Compat.jl
Outdated
|
|
||
| # Cope with renaming of RangeGeneratorInt to SamplerRangeInt | ||
| @static if !isdefined(Base.Random, :SamplerRangeInt) | ||
| SamplerRangeInt = Base.Random.RangeGeneratorInt |
| @@ -1063,6 +1063,8 @@ end | |||
| @test Compat.notnothing(1) == 1 | |||
| @test_throws ArgumentError Compat.notnothing(nothing) | |||
|
|
|||
| @test isa(Base.Random.RangeGenerator(1:3), Compat.Random.SamplerRangeInt) | |||
There was a problem hiding this comment.
Base.Random.RangeGenerator has been kept as an alias for compatibility, but eventually it will go; but I guess this test is fine for now. Also, Random will move to stdlib.
There was a problem hiding this comment.
I don't think the test should reference the obsolete name. Maybe
@test extrema([rand(Compat.Random.SamplerRangeInt(1:3)) for i=1:1000]) == (1,3)
|
This change looks good, do you have a link to an example where it would be used? It's possible that for |
|
This was designed for https://github.com/JuliaStats/Distributions.jl/pull/700/files. Happy to implement or defer to your implementation of a better approach; I just wanted to get Distributions.jl working again. |
|
I think we can go with your solution for now, and see if a better solution exists when things have stabilized after 1.0 is out. |
|
needs a rebase |
|
Any update on this? |
|
Updated on top of #601. The test of course fails on Julia past 0.7 as |
|
Closing as outdated since we've dropped support for Julia prior to 1.0. |
No description provided.