Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdin/stdout/stderr and devnull #499

Merged
merged 5 commits into from
Feb 24, 2018
Merged

stdin/stdout/stderr and devnull #499

merged 5 commits into from
Feb 24, 2018

Conversation

stevengj
Copy link
Member

@stevengj stevengj commented Feb 23, 2018 •
edited
Loading

Updated version of #498 to use @compat _redirect_* for JuliaLang/julia#25959.

@stevengj
Copy link
Member Author

CI failure on Windows is unrelated download error.

ararslan
ararslan reviewed Feb 23, 2018
View reviewed changes
src/Compat.jl Outdated
include("compatmacro.jl")

@static if !isdefined(Base, :devnull) #25959
export devnull
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 space indent?

@ararslan
Copy link
Member

@mbauman suggested that we override Base._redirect_* here, which seems like it could be a cleaner solution.

@stevengj
Copy link
Member Author

Updated to use _redirect_*, which should work for anything that doesn't explicitly mutate STDOUT (like IJulia does — it will just need a VERSION check).

I kept the change moving @compat to a separate file, since it still seems cleaner to separate this out, but the macro is unchanged.

@ararslan ararslan requested a review from mbauman February 23, 2018 23:44
@stevengj
Copy link
Member Author

Usual unrelated download error on AppVeyor

@stevengj stevengj merged commit 7434380 into master Feb 24, 2018
@stevengj stevengj deleted the stdout branch February 24, 2018 00:00
@martinholters
Copy link
Member

Any idea what's up here?

julia> VERSION
v"0.6.0"

julia> using Compat: stderr

julia> print(STDERR, "\r")

julia> print(stderr, "\r")

signal (11): Segmentation fault
while loading no file, in expression starting on line 0
uv_write2 at deps/srccache/libuv-52d72a52cc7ccd570929990f010ed16e2ec604c8/src/unix/stream.c:1389
uv_write at deps/srccache/libuv-52d72a52cc7ccd570929990f010ed16e2ec604c8/src/unix/stream.c:1475
jl_uv_write at src/jl_uv.c:414
uv_write at ./stream.jl:798
unsafe_write at ./stream.jl:832
print at ./strings/io.jl:122
unknown function (ip: 0x7f7c5b6e9556)
jl_call_fptr_internal at src/julia_internal.h:339 [inlined]
jl_call_method_internal at src/julia_internal.h:358 [inlined]
jl_apply_generic at src/gf.c:1933
do_call at src/interpreter.c:75

(Yea, I'll give 0.6.2 a try...)

@martinholters
Copy link
Member

Confirmed on 0.6.2. Also note:

julia> using Compat: stderr

julia> stderr === STDERR
false

Should the assignment happen in __init()__?

@stevengj
Copy link
Member Author

I guess so?

@stevengj
Copy link
Member Author

Since this is an urgent bugfix, I pushed it directly: e39939a

martinholters added a commit that referenced this pull request Sep 29, 2019
@martinholters
Drop compat code for devnull, stdin, stdout, and stderr from #…
2543a7f 
…499
martinholters added a commit that referenced this pull request Sep 29, 2019
@martinholters
Drop compat code for devnull, stdin, stdout, and stderr from #…
d6c03b2 
…499
martinholters added a commit that referenced this pull request Oct 8, 2019
@martinholters
Drop compat code for devnull, stdin, stdout, and stderr from #…
f16e3e5 
…499
martinholters added a commit that referenced this pull request Oct 13, 2019
@martinholters
Drop support for Julia versions <1.0 (#665)
4fa5519 
* Bump required Julia version to 1.0

* Remove compatibility support code for:
  * `at-__MODULE__` (from #363)
  * `devnull`, `stdin`, `stdout`, and `stderr` from #499
  * `at-nospecialize` (from #385 and #409)
  * `isabstracttype` and `isconcretetype` (from #477)
  * `invokelatest` from #424
  * array-like access to `Cmd` from #379
  * `Val(n)` and `ntuple`/`reshape` with `Val` from #381 and #399
  * `logdet(::Any)` fallback from #382
  * `chol(::UniformScaling)` from #382
  * `pushfirst!`, `popfirst!` from #444
  * `fieldcount` from #386
  * `read(obj, ::Type{String})` from #385 and #580
  * `InexactError`, `DomainError`, and `OverflowError` constructors from #393
  * `corrected` kw arg to `cov` from #401
  * `adjoint` from #401
  * `partialsort` from #401
  * `pairs` from #428
  * `AbstractRange` from #400
  * `rtoldefault` from #401
  * `Dates.Period` rounding from #462
  * `IterativeEigensolvers` from #435
  * `occursin` from #520
  * `Char` concatenation from #406
  * `BitSet` from #407
  * `diagm` and `spdiagm` with pairs from #408
  * `Array` c'tors from `UniformScaling` from #412 and #438
  * `IOContext` ctor taking pairs from #427
  * `undef` from #417 and #514
  * `get` on `ENV` from #430
  * `ComplexF...` from #431
  * `tr` from #614
  * `textwidth` from #644
  * `isnumeric` from #543
  * `AbstractDict` from #435
  * `axes` #435 and #442
  * `Nothing` and `Cvoid` from #435
  * `Compat.SuiteSparse` from #435
  * `invpermute!` from #445
  * `replace` with a pair from #445
  * `copyto!` from #448
  * `contains` from #452
  * `CartesianIndices` and `LinearIndices` from #446, #455, and #524
  * `findall` from #466 (and #467).
  * `argmin` and `argmax` from #470, #472, and #622
  * `parentmodule` from #461
  * `codeunits` from #474
  * `nameof` from #471
  * `GC` from #477
  * `AbstractDisplay` from #482
  * `bytesavailable` from #483
  * `firstindex` and `lastindex` from #480 and #494
  * `printstyled` from #481
  * `hasmethod` from #486
  * `objectid` from #486
  * `Compat.find*` from #484 and #513
  * `repr` and `showable` from #497
  * `Compat.names` from #493 and #505
  * `Compat.round` and friends #500, #530, and #537
  * `IOBuffer` from #501 and #504
  * `range` with kw args and `LinRange` from #511
  * `cp` and `mv` from #512
  * `indexin` from #515
  * `isuppercase` and friends from #516
  * `dims` and `init` kwargs from #518, #528, #590, #592, and #613
  * `selectdim` from #522 and #531
  * `repeat` from #625
  * `fetch(::Task)` from #549
  * `isletter` from #542
  * `isbitstype` from #560
  * `at-cfunction` from #553 and #566
  * `codeunit` and `thisind` and friends from #573
  * `something` from #562
  * `permutedims` from #582
  * `atan` from #574
  * `split` and `rsplit` from #572
  * `mapslices` from #588
  * `floatmin` and `floatmax` from #607
  * `dropdims` from #618
  * required keyword arguments from #586
  * `CartesianRange` in `at-compat` from #377
  * `finalizer` from #416
  * `readline`, `eachline`, and `readuntil` from #477, #541, and #575
  * curried `isequal`, `==`, and `in` from #517
  * `Some` from #435 and #563
  * `at-warn` and friends from #458

* Remove old deprecations

* Deprecate:
  * `Compat.Sockets` from #545 and #594
  * `TypeUtils` from #304
  * `macros_have_sourceloc` from #355
  * `Compat.Sys` from #380, #433, and #552
  * `Compat.MathConstants` from #401
  * `Compat.Test`, `Compat.SharedArrays`, `Compat.Mmap`, and `Compat.DelimitedFiles` from #404
  * `Compat.Dates` from #413
  * `Compat.Libdl` from #465 (and #467)
  * `AbstractDateTime` from #443
  * `Compat.Printf` from #435
  * `Compat.LinearAlgebra` from #463
  * `Compat.SparseArrays` from #459
  * `Compat.Random` from #460, #601, and #647
  * `Compat.Markdown` from #492
  * `Compat.REPL` from #469
  * `Compat.Serialization` from #473
  * `Compat.Statistics` from #583
  * `Fix2` from #517
  * `Compat.Base64` from #418
  * `Compat.Unicode` from #432 and #507
  * `notnothing` from #435 and #563
  * `Compat.IteratorSize` and `Compat.IteratorEltype` from #451
  * `enable_debug(::Bool)` from #458
  * `Compat.Distributed` from #477
  * `Compat.Pkg` from #485
  * `Compat.InteractiveUtils` from #485
  * `Compat.LibGit2` from #487
  * `Compat.UUIDs` from #490
  * `Compat.qr` from #534
  * `Compat.rmul!` from #546
  * `Compat.norm` abd friends from #577

* Remove obsolete README entry, missed in #385

* Remove obsolete tests (e.g. missed in #372)

* Remove obsolete `VERSION` conditionals and some minor clean-up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan left review comments

@mbauman mbauman mbauman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevengj @ararslan @martinholters @mbauman