Add dot(x,A,y)

[mcabbott]

This adds most of JuliaLang/julia#32739.

I got tired of copying and skipped some of the more exotic matrix types. They should all hit the generic fallback though, so should still work.

I commented out bits of src/deprecated.jl to make tests pass. I’m not too sure what those are meant to do, and whether they are still needed post-1.0?

[martinholters]

Removing the deprecations makes this a breaking change, which I'd like to avoid. If you use dot qualified everywhere (i.e. LinearAlgebra.dot), that should go a long way. What other problems appear with the deprecations in place?

[martinholters]

Ok, I've re-enabled the deprecations after some tweaking.

[martinholters]

Can we get some nicer code formatting here? E.g. no lines longer than 92 chars and import and using statements collected at the top. (Yes, I missed the opportunity to do so in the commit I've pushed.)

[mcabbott]

See if you like the current version, not strictly 92 but narrower than earlier things. And thanks for fixing the deprecations earlier!

[martinholters]

Generally looks good to me modulo some minor remarks.

Also, I'm not sure all methods are tested; especially I couldn't find tests for the generic fallback and the ::Diagonal one. (I may easily have missed them, though.)

[martinholters]

I'm not sure we should be using this. It's an internal function that might just go away eventually. Unless I missed something, it's used only once above, so we could just unconditionally replace it with its definition there. Or at least, we should move this block into the other conditional, so that Base.require_one_based_indexing is only resolved for Julia versions where we know it exists.

[mcabbott]

Indeed it's only used once now, although I think I have run into it elsewhere. The reason to add it was just to keep the dot methods as close to identically copied as possible, rather than inlining the definition.

But indeed if say Julia 1.9 renames this thing, Compat shouldn't break. I've now added a bound for the Base function too.

[mcabbott]

The generic case is tested, in that commenting it out leads to MethodError: no method matching dot(::Int64, ::Int64, ::Int64). I can't see a test for Diagonal in https://github.com/JuliaLang/julia/pull/32739/files , so I've invented one.

[martinholters]

I've added a merge of master and moved the README entry to the top of the list, and bumped the version to 3.2.0. Once CI is green, I'll merge and tag a release.