Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename default branch from master => main in ci.yml #67

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

NHDaly
Copy link
Member

@NHDaly NHDaly commented Jul 25, 2022

Since everyone usually has this set up with main as the default branch these days.

Or should I maybe add both instead?

@KristofferC
Copy link
Member

Since everyone usually has this set up with main as the default branch these days

I dont think that is true. Is there no way to do this so it works for any default branch? Otherwise, I think both should at least be listed.

@NHDaly
Copy link
Member Author

NHDaly commented Jul 25, 2022

I don't know much about this, so i don't know if there is or isn't any way to do just the default branch. Agreed that would be nice.

I'll set it up for both for now 👍

@NHDaly
Copy link
Member Author

NHDaly commented Jul 25, 2022

It doesn't look like they have any kind of support for default branch, unfortunately:
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#using-activity-types-and-filters-with-multiple-events

@ararslan ararslan merged commit 928ba3c into master Jul 25, 2022
@ararslan ararslan deleted the nhd-ci-master-main branch July 25, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants