This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
Blacklist the original Logging module for julia-0.7 #12653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately this module can't be installed with julia-0.7, as there's a clash with the new stdlib module of the same name.
15 tasks
|
@kmsquire hope you don't mind, I've merged this quickly without much discussions, since otherwise |
|
No worries! I’ve been following Chris’s logging development in Base, and
thought something like this would be needed. I haven’t really had time to
work on the Logging package much, and I’m glad Base now has better logging
functionality. Cheers!
…On Fri, Dec 29, 2017 at 5:44 AM Avik Sengupta ***@***.***> wrote:
@kmsquire <https://github.com/kmsquire> hope you don't mind, I've merged
this quickly without much discussions, since otherwise 0.7 is broken for
many people. I'll revert/re-fix it if we can come up with a solution.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12653 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANoEvTYrBcyBAD5RJz163Nv2SCUsy72ks5tFOy5gaJpZM4RPFAG>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately this module can't really be installed with julia-0.7, as there's a clash with the new stdlib module of the same name. See JuliaLang/julia#25182
Alternative and better solutions to this conundrum welcome.
To make
Logginginstallable again, I imagine we would need to rename it.CC @kmsquire, apologies for this mess.