Change https urls to git #402
Conversation
| @@ -11,7 +11,7 @@ for (pkg, versions) in Pkg.Read.available() | |||
| path=m.captures[5] | |||
| assert (path!=nothing , "Invalid url $url for package $(pkg). Cannot extract path") | |||
| scheme=m.captures[2] | |||
| assert ( ismatch (r"git", scheme) || ismatch (r"http", scheme), "Invalid url scheme $scheme for package $(pkg). Should be 'git' or 'http[s]'") | |||
| assert ( ismatch (r"git", scheme), "Invalid url scheme $scheme for package $(pkg). Should be 'git' ") | |||
There was a problem hiding this comment.
This test is really a bit iffy. It's actually fine to use any protocol that git supports. On GitHub specifically, we prefer git:// as the protocol.
There was a problem hiding this comment.
Yeah, you're right the test should be moved to the github block.
Change https urls to git
|
@aviks, I did a clone and see that 8 packages are still using https
|
|
@spayne That's on the See: I'm assuming the relevant changes will be copied via the |
Fix #400
Change all https:// urls in METADATA to git:// urls
Update tests to enforce git:// and fail https:// urls
I'll merge it if there are no objections.