fixes for cloning (+ help requested) #100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a problem with cloning when checking out #83.
I looked at https://discourse.julialang.org/t/why-mypackage-is-forcing-other-package-downgrade-with-an-unbounded-require and created a fork (https://github.com/KristofferC/OdsIO.jl) of that repo.
When I changed the REQUIRE file to
julia 0.6
and used Pkg2clone
it correctly used the latest version of DataFrames.However, when I cloned it in Pkg3, it was still getting a downgraded version of DataFrames. So I figured that compatibility info from the registry (for version 0.2.0 of OdsIO.jl) must somehow interfere. And yes, in #83, the identical version as the last registered version for the cloned package is used which will likely lead to problems when compatibility for the registered package with that version is added. Therefore I did the following change: https://github.com/JuliaLang/Pkg3.jl/compare/kc/clonerepo2-rebased...kc/no_deps_or_reqs_for_fixed?expand=1#diff-920ed338dcbd9d62489c6d12dc2fbb18R834 to put the version of the cloned package "above" the last registerd version, suspecting that that would fix the problem.
However, it did not.
Only when I stopped fixed packages from adding any compatibility or direct dependencies did the problem go away (the
uuid in keys(fixed) && continue
statements). Without that I still got:which indicates that compatibility for OdsIO is still holding DataFrames down.
@carlobaldassi Do you have an idea what is happening? It seems that the julia 0.5 requirement from 0.2.0 is still interfering, even though I put the cloned package to 0.2.0+.