Refactor and test `Pkg.test` #1427

00vareladavid · 2019-09-27T21:26:02Z

I want "targets" based testing to reuse the same machinery as "test/Project.toml" based testing. This will allow us to get rid of backwards_compatible_isolation.jl.

fix #1287 fix #1423

KristofferC · 2019-09-30T12:37:08Z

Regarding #311, it doesn't make much sense to me. You should probably set the environment variable yourself in that case.

KristofferC · 2019-09-30T18:21:33Z

src/Operations.jl

+
+function collect_developed!(ctx::Context, pkg::PackageSpec, developed::Vector{PackageSpec})
+    source = project_rel_path(ctx, source_path(pkg))
+    Pkg.activate(source) do


Instead of activating here, can't we give the path to Context? Something like Context(env = EnvCache(source)).

KristofferC · 2019-09-30T18:22:56Z

src/Operations.jl

+        pkgs = load_all_deps(Context())
+        for pkg in filter(is_tracking_path, pkgs)
+            # normalize path
+            pkg.path = project_rel_path(Context(), source_path(pkg))


Probably shouldn't remake the Context here every time?

KristofferC · 2019-09-30T18:24:54Z

src/Operations.jl

+            # normalize path
+            pkg.path = project_rel_path(Context(), source_path(pkg))
+            push!(developed, pkg)
+            collect_developed!(ctx, pkg, developed)


Is this trying to help with #1005?

KristofferC · 2019-09-30T18:34:57Z

src/Operations.jl

@@ -767,6 +793,16 @@ function dependency_order_uuids(ctx::Context, uuids::Vector{UUID})::Dict{UUID,In
    return order
 end

+function gen_build_project(ctx::Context, pkg::PackageSpec, source_path::String)
+    build_project = Types.Project()
+    Pkg.activate(source_path) do


Same here with path to Context

KristofferC · 2019-09-30T18:35:39Z

Would be great to get rid of that compat file!

KristofferC · 2019-10-01T15:09:45Z

test/repl.jl

@@ -394,6 +394,7 @@ temp_pkg_dir() do project_path; cd(project_path) do
    end # testset
 end end

+#=


You can get rid of the specific test that checks the LibFoo thing, but most of this should still be active.

KristofferC · 2019-11-19T11:37:20Z

src/API.jl

-dependencies(fn::Function, uuid::UUID) = fn(dependencies()[uuid])
+function dependencies(fn::Function, uuid::UUID)
+    dep = get(dependencies(), uuid, nothing)
+    if dep === nothing


I guess you could write this as

dep = get(dependencies, uuid) do pkgerror("depenendency with UUID `$uuid` does not exist") end

But I am not sure this is preferable even.

00vareladavid · 2019-12-01T00:04:46Z

I feel this is in a mergeable state now, if anyone wants to take another look.

I've tested most of the basic cases I can think of, hopefully we can pin down most of the Pkg.test behavior with these tests. Perhaps @fredrikekre you can take a quick look at the tests? Since you have been good about finding holes in Pkg.test.

I'll be happy to test any other cases that people can think of.

KristofferC · 2019-12-06T08:59:36Z

Great job! Nice to get rid of that duplication.

00vareladavid · 2019-12-09T21:39:12Z

I appreciate it Kristoffer. And thanks for the review!

KristofferC · 2019-12-16T16:50:20Z

I think this caused packages to fail during tests if they don't have a project file (for example: https://github.com/maleadt/BasePkgEvalReports/blob/adfa530cc2662ca9abd85544d3ed41aa6d0ad95f/pkgeval-daily_2019_12_16/logs/Permutations/1.4.0-DEV-a6bf74a2f9.log#L36-L65).

I think we need to try fix that.

00vareladavid · 2019-12-16T19:28:35Z

Definitely. Taking a look now

00vareladavid force-pushed the 00/rework/isolation branch from 817758a to e1bb47e Compare September 28, 2019 05:09

This comment has been minimized.

Sign in to view

00vareladavid force-pushed the 00/rework/isolation branch 4 times, most recently from 71a307c to 54cf424 Compare September 30, 2019 03:12

KristofferC reviewed Sep 30, 2019

View reviewed changes

KristofferC reviewed Oct 1, 2019

View reviewed changes

00vareladavid force-pushed the 00/rework/isolation branch 7 times, most recently from 1083339 to ad55c39 Compare November 19, 2019 07:55

00vareladavid closed this Nov 19, 2019

00vareladavid reopened this Nov 19, 2019

00vareladavid force-pushed the 00/rework/isolation branch from 7b0cadf to b03c53b Compare November 19, 2019 08:37

KristofferC reviewed Nov 19, 2019

View reviewed changes

00vareladavid mentioned this pull request Nov 19, 2019

Add test for target deps for dependencies #383

Closed

00vareladavid changed the title ~~[WIP] Refactor Pkg.test~~ Refactor and test Pkg.test Nov 20, 2019

KristofferC mentioned this pull request Nov 30, 2019

compat install_archive needs update to new protocal #1514

Closed

StefanKarpinski mentioned this pull request Dec 1, 2019

fix #1514: install_archive call in backwards_compatible_isolation #1517

Merged

00vareladavid force-pushed the 00/rework/isolation branch from a3b67eb to e57f1ed Compare December 6, 2019 03:29

00vareladavid added 12 commits December 9, 2019 10:23

Refactor Pkg.test

302c20c

remove backwards_compatible_isolation.jl

ddcf9f6

disable one test (for now)

8011bfe

Support for dev test deps

34f7fa8

Remove test for issue 306

aafb66d

avoid activate when not necessary

8a71eff

Test nodes tracking a path

c79b74e

Allow active project to be loaded

d077147

test sandbox honors compat

10cf40b

support active project as test target dependency

5e66290

"targets" test honors compat

c99e580

more tests

85aad86

00vareladavid force-pushed the 00/rework/isolation branch 2 times, most recently from e754718 to 97b2752 Compare December 9, 2019 18:28

Pkg.test should work on readonly directories

2067980

00vareladavid force-pushed the 00/rework/isolation branch from 97b2752 to 2067980 Compare December 9, 2019 21:19

00vareladavid closed this Dec 9, 2019

00vareladavid reopened this Dec 9, 2019

00vareladavid merged commit d69f6d7 into JuliaLang:master Dec 9, 2019

00vareladavid deleted the 00/rework/isolation branch December 9, 2019 22:14

DilumAluthge mentioned this pull request Dec 17, 2019

Packages fail during tests if they don't have a Project.toml file #1550

Closed

This was referenced Dec 17, 2019

provide a fallback when sandboxing a package with no Project.toml #1549

Merged

remove some unnecessary struct fields #1559

Merged

00vareladavid mentioned this pull request Dec 27, 2019

Scary error message in CI log #1565

Closed

00vareladavid mentioned this pull request Jan 4, 2020

'test' can't find local package when dev'd in test/Project.toml #1587

Closed

KristofferC mentioned this pull request Apr 18, 2020

Cannot convert an object of type Pkg.Types.VersionSpec to an object of type VersionNumber #1570

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor and test `Pkg.test` #1427

Refactor and test `Pkg.test` #1427

00vareladavid commented Sep 27, 2019 •

edited

Loading

This comment has been minimized.

KristofferC commented Sep 30, 2019

KristofferC Sep 30, 2019

KristofferC Sep 30, 2019 •

edited

Loading

KristofferC Sep 30, 2019

KristofferC Sep 30, 2019

KristofferC commented Sep 30, 2019

KristofferC Oct 1, 2019

KristofferC Nov 19, 2019

00vareladavid commented Dec 1, 2019 •

edited

Loading

KristofferC commented Dec 6, 2019

00vareladavid commented Dec 9, 2019

KristofferC commented Dec 16, 2019

00vareladavid commented Dec 16, 2019

Refactor and test Pkg.test #1427

Refactor and test Pkg.test #1427

Conversation

00vareladavid commented Sep 27, 2019 • edited Loading

This comment has been minimized.

KristofferC commented Sep 30, 2019

KristofferC Sep 30, 2019

Choose a reason for hiding this comment

KristofferC Sep 30, 2019 • edited Loading

Choose a reason for hiding this comment

KristofferC Sep 30, 2019

Choose a reason for hiding this comment

KristofferC Sep 30, 2019

Choose a reason for hiding this comment

KristofferC commented Sep 30, 2019

KristofferC Oct 1, 2019

Choose a reason for hiding this comment

KristofferC Nov 19, 2019

Choose a reason for hiding this comment

00vareladavid commented Dec 1, 2019 • edited Loading

KristofferC commented Dec 6, 2019

00vareladavid commented Dec 9, 2019

KristofferC commented Dec 16, 2019

00vareladavid commented Dec 16, 2019

Refactor and test `Pkg.test` #1427

Refactor and test `Pkg.test` #1427

00vareladavid commented Sep 27, 2019 •

edited

Loading

KristofferC Sep 30, 2019 •

edited

Loading

00vareladavid commented Dec 1, 2019 •

edited

Loading