Refactor: use VersionSpec as the canonical compat representation
#2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
approved these changes
Apr 2, 2021
|
Out of curiosity, what happens if the |
|
Then you will have a bug when you write the TOML file. An assert could be added for the project writer that checks that the string is in sync. That is indeed probably a good idea. |
That sounds good. @00vareladavid want to do this in this PR? Alternatively we can merge this PR, and add the check in the follow-up PR. |
|
Ok, I added the check 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the discussion in #2469. As stated in the discussion. a VersionSpec is a much more desirable representation because it can be modified more easily.
Changes:
VersionSpecwhen reading project file