update note on package extensions #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
reviewed
Apr 25, 2023
docs/src/creating-packages.md
Outdated
| get the functionality from the extension. The other way round does not work, i.e., if you load a package having | ||
| an extension from a project environment and then load the package required for the extension from you main/default | ||
| environment, the extension will not be loaded. This is different from the behavior of Requires.jl. Thus, package | ||
| extensions are not full replacements of the behavior of Requires.jl. |
There was a problem hiding this comment.
I would suggest removing the last sentence since it doesn't really add anything. You have already described the difference. Perhaps the sentence before it can be made more explicit, something like
This is different from the behavior of Requires.jl where the conditional code is evaluated no matter from what environment the "extension dependency" is loaded
maybe?
There was a problem hiding this comment.
Good suggestion. I updated the text accordingly.
|
bump |
IanButterworth
pushed a commit
to IanButterworth/Pkg.jl
that referenced
this pull request
May 17, 2023
(cherry picked from commit 6f02014)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on a discussion with @KristofferC.
Closes JuliaLang/julia#49497