-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip allow for op suffixes #117
Conversation
@ZacLN As discussed with @Keno, there are two ways to handle this. One is either as in this PR, to have a custom "operator suffix" |
My intuition is that this is the better approach |
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
- Coverage 76.15% 75.49% -0.66%
==========================================
Files 4 4
Lines 847 857 +10
==========================================
+ Hits 645 647 +2
- Misses 202 210 +8
Continue to review full report at Codecov.
|
@ZacLN @KristofferC Are we good with this approach? If so, shall we merge? |
Can I have a think on how to implement it in cstparser first? I'll have a look this weekend |
Bump! |
Sorry for delay. Thoughts- this doesn't do the job properly. There's no ambiguity in these cases and no reliance on context (above what is known at the Similarly, do the changes in v0.7 make use of dot operators unambiguous? i.e. should they be handled to return a single TOken at this level? EDIT: Further thoughts: introduce an extra function call before emitting an operator that checks for suffixes and appends it to the |
An example for dotted operator handling handling |
Superseded by #129 |
Ref JuliaLang/julia#22089 (comment)