fix #10540

specialize map!(f,A) as well
JuliaLang · Mar 17, 2015 · 2a4fd44 · 2a4fd44
1 parent b201312
commit 2a4fd44
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/base/abstractarray.jl b/base/abstractarray.jl
@@ -1283,7 +1283,7 @@ function map_promote(f, A::AbstractArray)
 end
 
 ## 1 argument
-map!(f, A::AbstractArray) = map!(f, A, A)
+map!{F}(f::F, A::AbstractArray) = map!(f, A, A)
 function map!{F}(f::F, dest::AbstractArray, A::AbstractArray)
     for i = 1:length(A)
         dest[i] = f(A[i])

diff --git a/test/functional.jl b/test/functional.jl
@@ -2,7 +2,11 @@
 
 # map -- array.jl
 @test isequal(map((x)->"$x"[end:end], 9:11), ["9", "0", "1"])
-# TODO: @test map!()
+# TODO: @test map!() much more thoroughly
+let a = [1.0, 2.0]
+    map!(sin, a)
+    @test isequal(a, sin([1.0, 2.0]))
+end
 # map -- ranges.jl
 @test isequal(map(i->sqrt(i), 1:5), [sqrt(i) for i in 1:5])
 @test isequal(map(i->sqrt(i), 2:6), [sqrt(i) for i in 2:6])