Clear specsigflags correctly for copied code instance (#50238)

As provided by Jameson to fix an issue encountered in a downstream project. Co-authored-by: Jameson Nash <[email protected]>
JuliaLang · Jun 21, 2023 · 4f0216a · 4f0216a · nanosoldier · Jun 21, 2023
1 parent 94dd5cf
commit 4f0216a
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/gf.c b/src/gf.c
@@ -2392,7 +2392,8 @@ jl_code_instance_t *jl_compile_method_internal(jl_method_instance_t *mi, size_t
                 if (jl_atomic_cmpswap_acqrel(&codeinst->specptr.fptr, &prev_fptr, fptr)) {
                     jl_atomic_store_relaxed(&codeinst->specsigflags, specsigflags & 0b1);
                     jl_atomic_store_release(&codeinst->invoke, invoke);
-                    jl_atomic_store_release(&codeinst->specsigflags, specsigflags);
+                    // unspec is probably not specsig, but might be using specptr
+                    jl_atomic_store_release(&codeinst->specsigflags, specsigflags & ~0b1); // clear specsig flag
                 } else {
                     // someone else already compiled it
                     while (!(jl_atomic_load_acquire(&codeinst->specsigflags) & 0b10)) {