Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait(condition) while running an @async task can not be interrupted by ctrl-c #13075

Closed
tehrengruber opened this issue Sep 11, 2015 · 3 comments
Assignees
Labels
regression Regression in behavior compared to a previous version

Comments

@tehrengruber
Copy link

Consider the following 2 scenarios

Scenario 1

cond = Condition()
wait(cond)

# press ctrl-c
#^CERROR: InterruptException:

Scenario 2

cond = Condition()

@async begin
    while true
        sleep(1)
        println(1)
    end
end

wait(cond)

# press ctrl-c
#^CERROR (unhandled task failure): InterruptException:
#^CERROR (unhandled task failure): InterruptException:
# ...

Now in scenario 1 pressing ctrl-c just interrupts the wait call und you get back to the prompt and everthings fine

But in scenario 2 pressing ctrl-c actually interrupts the task and not the wait call. Which is not correct I guess and even worse after the task was interrupted you are stuck and you won't get back to the prompt.

@JeffBezanson JeffBezanson self-assigned this Sep 15, 2015
@JeffBezanson
Copy link
Member

I believe I fixed this in #10416, and it regressed.

@JeffBezanson JeffBezanson added regression Regression in behavior compared to a previous version backport pending 0.4 labels Sep 15, 2015
@tkelman
Copy link
Contributor

tkelman commented Sep 16, 2015

any reasonable way of testing for this?

JeffBezanson added a commit that referenced this issue Sep 16, 2015
(cherry picked from commit 391301e)
@tkelman
Copy link
Contributor

tkelman commented Sep 16, 2015

backported in #13107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Regression in behavior compared to a previous version
Projects
None yet
Development

No branches or pull requests

3 participants