Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oops, your femto is showing #23135

Closed
quinnj opened this issue Aug 5, 2017 · 1 comment · Fixed by #23202
Closed

Oops, your femto is showing #23135

quinnj opened this issue Aug 5, 2017 · 1 comment · Fixed by #23202
Labels
compiler:lowering Syntax lowering (compiler front end, 2nd stage)

Comments

@quinnj
Copy link
Member

quinnj commented Aug 5, 2017 •
edited
Loading 

               _
   _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: https://docs.julialang.org
   _ _   _| |_  __ _   |  Type "?help" for help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 0.7.0-DEV.1172 (2017-07-30 03:30 UTC)
 _/ |\__'_|_|_|\__'_|  |  jb/namedtuples/88b3137b32* (fork: 10 commits, 6 days)
|__/                   |  x86_64-apple-darwin16.7.0

julia> @goto done
ERROR: syntax: label "(outerref done)" referenced but not defined
@JeffBezanson
Copy link
Member

I think the fix here would be to avoid wrapping label names in outerref.

@JeffBezanson JeffBezanson added the compiler:lowering Syntax lowering (compiler front end, 2nd stage) label Aug 5, 2017
vtjnash added a commit that referenced this issue Aug 9, 2017
@vtjnash
fix macro goto/label hygiene
94ff992 
same basic idea as PR #22985 did for macro variables
also fixes #23135
vtjnash added a commit that referenced this issue Aug 10, 2017
@vtjnash
fix macro goto/label hygiene
ce6f4ae 
same basic idea as PR #22985 did for macro variables
also fixes #23135
@vtjnash vtjnash mentioned this issue Aug 10, 2017
Merged
vtjnash added a commit that referenced this issue Aug 11, 2017
@vtjnash
fix macro goto/label hygiene
c70b2c4 
same basic idea as PR #22985 did for macro variables
also fixes #23135
vtjnash added a commit that referenced this issue Aug 16, 2017
@vtjnash
fix macro goto/label hygiene (#23202)
271f210 
same basic idea as PR #22985 did for macro variables
also fixes #23135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler:lowering Syntax lowering (compiler front end, 2nd stage)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix macro goto/label hygiene JuliaLang/julia
2 participants
@JeffBezanson @quinnj