Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qualify macro names used for parsing big int literals #29968

Closed
JeffBezanson opened this issue Nov 8, 2018 · 1 comment
Closed

qualify macro names used for parsing big int literals #29968

JeffBezanson opened this issue Nov 8, 2018 · 1 comment
Assignees
@JeffBezanson
Labels
minor change Marginal behavior change acceptable for a minor release parser Language parsing and surface syntax
Milestone
1.1

Comments

@JeffBezanson
Copy link
Member

See https://discourse.julialang.org/t/altering-parse-eval-behavior-without-overriding-methods-in-base/17290

We parse these as (macrocall @int128_str ...), which should be (macrocall (top @int128_str) ...).

The same seems to apply to backquotes and @cmd.
@JeffBezanson JeffBezanson added parser Language parsing and surface syntax triage This should be discussed on a triage call minor change Marginal behavior change acceptable for a minor release labels Nov 8, 2018
@JeffBezanson JeffBezanson added this to the 1.1 milestone Nov 8, 2018
@StefanKarpinski
Copy link
Member

Triage (absent Jeff) is cool with this.

@StefanKarpinski StefanKarpinski removed the triage This should be discussed on a triage call label Nov 15, 2018
@JeffBezanson JeffBezanson self-assigned this Nov 28, 2018
JeffBezanson added a commit that referenced this issue Nov 28, 2018
@JeffBezanson
fix #29968, qualify macro names in parsing int literals and cmds
02007bd
@JeffBezanson JeffBezanson mentioned this issue Nov 28, 2018
Merged
JeffBezanson added a commit that referenced this issue Nov 29, 2018
@JeffBezanson
fix #29968, qualify macro names in parsing int literals and cmds (#30181
15f649c 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffBezanson JeffBezanson

Labels
minor change Marginal behavior change acceptable for a minor release parser Language parsing and surface syntax
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
2 participants
@StefanKarpinski @JeffBezanson