-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nullables test error on 1.1.0 branch #30344
Labels
Milestone
Comments
Removing |
"MWE" : using Compat
struct Nullable{T}
hasvalue::Bool
value::T
Nullable{T}() where {T} = new(false)
Nullable{T}(value::T, hasvalue::Bool=true) where {T} = new(hasvalue, value)
end
@inline function Base.isequal(x::Nullable{S}, y::Nullable{T}) where {S,T}
isequal(x.value, y.value)
end
isequal(Nullable{Bool}(), Nullable{Int8}(Int8(0))) (this seems to just hang in stead). |
Since we don't seem to have a "blocker" tag, I've put "priority" on this—this is causing breakage in released packages, which means this blocks the release of 1.1. |
vtjnash
added a commit
that referenced
this issue
Dec 11, 2018
We don't have a way to mark that the slot may contain invalid data, so just eagerly load it so we can sanitize the value immediately in case it is garbage. fix #30344
vtjnash
added a commit
that referenced
this issue
Dec 12, 2018
We don't have a way to mark that the slot may contain invalid data, so just eagerly load it so we can sanitize the value immediately in case it is garbage. fix #30344
JeffBezanson
pushed a commit
that referenced
this issue
Dec 12, 2018
We don't have a way to mark that the slot may contain invalid data, so just eagerly load it so we can sanitize the value immediately in case it is garbage. fix #30344
KristofferC
pushed a commit
that referenced
this issue
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Repro is:
The text was updated successfully, but these errors were encountered: