Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

searchsorted segfaults with offset arrays #33977

Closed
dlfivefifty opened this issue Nov 28, 2019 · 0 comments · Fixed by #34106
Closed

searchsorted segfaults with offset arrays #33977

dlfivefifty opened this issue Nov 28, 2019 · 0 comments · Fixed by #34106

Comments

@dlfivefifty
Copy link
Contributor 

julia> using OffsetArrays

julia> o = OffsetArray([2,2,3],-1:1)
3-element OffsetArray(::Array{Int64,1}, -1:1) with eltype Int64 with indices -1:1:
 
2
 2
 3

julia> searchsorted(o,1)
Segmentation fault: 11

This is due to

julia> (-2) >>> 1
9223372036854775807

which triggers:

julia/base/sort.jl

Line 178 in 25beaf5

m = (lo + hi) >>> 1

Crossref JuliaArrays/OffsetArrays.jl#85
@dlfivefifty dlfivefifty mentioned this issue Nov 29, 2019
Merged
timholy added a commit that referenced this issue Dec 15, 2019
@timholy
Use safer computation of midpoint in sorting (fixes #33977)
1e8d5f4
@timholy timholy mentioned this issue Dec 15, 2019
Merged
timholy added a commit that referenced this issue Dec 15, 2019
@timholy
Sign-aware computation of midpoint in sorting (fixes #33977)
5664788
timholy added a commit that referenced this issue Dec 15, 2019
@timholy
Sign-aware computation of midpoint in sorting (fixes #33977)
cec4b81
timholy added a commit that referenced this issue Dec 16, 2019
@timholy
Sign-aware computation of midpoint for sorting (fixes #33977)
0738131
timholy added a commit that referenced this issue Dec 16, 2019
@timholy
Sign-aware computation of midpoint for sorting (fixes #33977)
fd838be
timholy added a commit that referenced this issue Dec 16, 2019
@timholy
Sign-aware computation of midpoint for sorting (fixes #33977)
ce15bbb
timholy added a commit that referenced this issue Dec 23, 2019
@timholy
Sign-aware computation of midpoint for sorting (fixes #33977)
fe7006d
timholy added a commit that referenced this issue Dec 23, 2019
@timholy
Sign-aware computation of midpoint for sorting (fixes #33977) (#34106)
4a8ea8c
@KristofferC KristofferC mentioned this issue Feb 20, 2020
Closed
56 tasks
KristofferC pushed a commit that referenced this issue Apr 11, 2020
@timholy @KristofferC
Sign-aware computation of midpoint for sorting (fixes #33977) (#34106)
3972549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use safer computation of midpoint in sorting (fixes #33977) JuliaLang/julia
1 participant
@dlfivefifty