Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for begin in at-view/at-views #35289

Merged
merged 3 commits into from
Apr 23, 2020

Conversation

sostock
Copy link
Contributor

@sostock sostock commented Mar 28, 2020

Fixes #35115.

This adds support for expressions like @view A[begin:end] where previously only end was supported.

@ararslan ararslan added needs news A NEWS entry is required for this change needs compat annotation Add !!! compat "Julia x.y" to the docstring labels Mar 28, 2020
@sostock
Copy link
Contributor Author

sostock commented Mar 30, 2020

I added a NEWS item and compat annotations.

@mbauman mbauman removed needs compat annotation Add !!! compat "Julia x.y" to the docstring needs news A NEWS entry is required for this change labels Apr 20, 2020
@tpapp
Copy link
Contributor

tpapp commented Apr 23, 2020

Friendly bump — I wonder if this could get merged at some point, it provides a very nice fix for the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrays [a, r, r, a, y, s]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

begin for @view
6 participants