Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use replace_ref_begin_end! on Julia >= 1.5.0-DEV.666 #84

Merged
merged 3 commits into from
Apr 26, 2020
Merged

Conversation

devmotion
Copy link
Member

Fix error on Julia master since replace_ref_end! was removed in JuliaLang/julia#35289.

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   77.46%   77.46%           
=======================================
  Files          13       13           
  Lines         821      821           
=======================================
  Hits          636      636           
  Misses        185      185           
Impacted Files Coverage Δ
src/varname.jl 76.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7159cb...28ac83f. Read the comment docs.

@devmotion
Copy link
Member Author

I removed the tests for begin for now since they caused errors on Julia 1.0 it seems...

@devmotion
Copy link
Member Author

devmotion commented Apr 24, 2020

Seems there is another problem on master, tests reach the time out limit but that could be related to the use of Turing in our tests leading to some compilation problems?

@yebai yebai merged commit 3f465bc into master Apr 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the ref_begin_end branch April 26, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants