You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently get this compiler warning when compiling the master branch:
.../julia/src/threading.c:187:32: warning: ‘jl_get_ptls_states_wrapper’ defined but not used [-Wunused-function]
187 | static JL_CONST_FUNC jl_ptls_t jl_get_ptls_states_wrapper(void) JL_GLOBALLY_ROOTED JL_NOTSAFEPOINT
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
There are no references to jl_get_ptls_states_wrapper anywhere I could find, and anyway, it is static. So it could be removed. Except that one comment suggests that it is meant to be accessible by code linking against libjulia. Except it isn't, as far as I can tell. An oversight?
Perhaps I am wrong and this is accessible, via some black magic. Then I still think there is an issue here: the code really should have a comment explaining this.
The text was updated successfully, but these errors were encountered:
Currently get this compiler warning when compiling the master branch:
There are no references to
jl_get_ptls_states_wrapper
anywhere I could find, and anyway, it is static. So it could be removed. Except that one comment suggests that it is meant to be accessible by code linking against libjulia. Except it isn't, as far as I can tell. An oversight?Perhaps I am wrong and this is accessible, via some black magic. Then I still think there is an issue here: the code really should have a comment explaining this.
The text was updated successfully, but these errors were encountered: