Remove unused jl_get_ptls_states_wrapper, update comments #39066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yuyichao Could you please elaborate on your "thumbs down"? I would absolutely not be surprised if this PR is the wrong way to go, and instead |
fingolfin
force-pushed
the
mh/jl_get_ptls_states_wrapper
branch
from
78094e8 to
1033595
Compare
staticfloat
approved these changes
Jan 5, 2021
fingolfin
force-pushed
the
mh/jl_get_ptls_states_wrapper
branch
from
1033595 to
b6f368b
Compare
Since jl_get_ptls_states_wrapper is static, it can't be called by outside code.
fingolfin
force-pushed
the
mh/jl_get_ptls_states_wrapper
branch
from
b6f368b to
96485a4
Compare
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…39066) Since jl_get_ptls_states_wrapper is static, it can't be called by outside code.
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…39066) Since jl_get_ptls_states_wrapper is static, it can't be called by outside code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since jl_get_ptls_states_wrapper is static, it can't be called by outside code.
For some context: that function and the comments were added in as part of an optimization in PR #17220 by @yuyichao, but the code accessing it was removed in PR #38160 by @staticfloat.
I am not sure how much of the remaining comment is actually accurate, perhaps more of it ought to be removed.
Resolves #38924