-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown autolink resolution _is_mailto can fail with bad string indexing #42139
Comments
KristofferC
pushed a commit
that referenced
this issue
Sep 8, 2021
KristofferC
pushed a commit
that referenced
this issue
Sep 9, 2021
KristofferC
pushed a commit
that referenced
this issue
Oct 29, 2021
KristofferC
pushed a commit
that referenced
this issue
Nov 11, 2021
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this issue
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this issue
Mar 8, 2022
staticfloat
pushed a commit
that referenced
this issue
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This was reported by a Franklin user but ended up being a bug with the Markdown module:
This is because Markdown sees the
< ... >
and tries to form an auto link and seems to be using string indexing in doing so. CommonMark.jl handles this wellactually reading the full stack trace points to
_is_mailto
being the culpritjulia/stdlib/Markdown/src/Common/inline.jl
Lines 151 to 156 in bb5b98e
ironically there's a comment specifying that it's a bit risky to be slicing the string (also it's a bit odd to check the first 6 characters with a 7 character string)
A suggestion would be to replace
julia/stdlib/Markdown/src/Common/inline.jl
Lines 154 to 155 in bb5b98e
using
first
andnextind
, I opened a PR with this here: #42140The text was updated successfully, but these errors were encountered: