-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mod2pi broken with USE_SYSTEM_LIBM #5365
Comments
We can bring the arm and powerpc bits into openlibm from FreeBSD msun at the right time. |
We should try to make |
Let's just have a Julia implementation of it. |
This could also be a good time to add a BigFloat version of it. |
I am going to copy this into |
This makes me think it would be nice to list the minimum openspecfun version required by Julia in the docs (and bump the version in openspecfun). A packager not aware of this issue wouldn't have noticed this requirement. |
I did bump the openspecfun and openlibm versions. |
Cc: @staticfloat @sebastien-villemot |
Interesting, now that the issue with |
Perhaps they were computed in a different rounding mode? |
Should I make releases for openlibm and openspecfun 0.4? I need them to build packages for Julia RC1. |
I think we should fix the SONAME stuff ideally before we do that. What do you think? |
Right. Should be pretty easy. |
Currently
mod2pi
calls__ieee754_rem_pio2
, which is an openlibm specific function. This causesmake test
to fail if julia is compiled w/USE_SYSTEM_LIBM=1
.Not really a big deal right now, but w/ ARM & PowerPC ports on the horizon, it would be nice to fix, since openlibm is likely to remain Intel-only.
The text was updated successfully, but these errors were encountered: