Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading test "relocatable upgrades" fails locally #53885

Closed
IanButterworth opened this issue Mar 28, 2024 · 3 comments · Fixed by #53889
Closed

Loading test "relocatable upgrades" fails locally #53885

IanButterworth opened this issue Mar 28, 2024 · 3 comments · Fixed by #53889
Labels
packages Package management and loading

Comments

@IanButterworth
Copy link
Member

@staticfloat @fatteneder it seems potentially problematic that this test added in #51989 fails locally but not on CI.

I added a @show to see the contents of the dir

loading    (1) |         failed at 2024-03-28T11:25:42.333
Test Failed at /Users/ian/Documents/GitHub/julia/usr/share/julia/test/loading.jl:1402
  Expression: length(filter(endswith(".ji"), readdir(foo_compiled_path))) == 1
   Evaluated: 2 == 1

Test Failed at /Users/ian/Documents/GitHub/julia/usr/share/julia/test/loading.jl:1403
  Expression: filesize(cache_path) != cache_size
   Evaluated: 1092 != 1092

readdir(foo_compiled_path) = ["Or1XO_bUlBJ.dylib", "Or1XO_bUlBJ.dylib.dSYM", "Or1XO_bUlBJ.ji", "Or1XO_mVdBs.dylib", "Or1XO_mVdBs.dylib.dSYM", "Or1XO_mVdBs.ji"]

julia/test/loading.jl

Lines 1400 to 1401 in 1172d6b

@test length(filter(endswith(".ji"), readdir(foo_compiled_path))) == 1
@test filesize(cache_path) != cache_size

@IanButterworth IanButterworth added the packages Package management and loading label Mar 28, 2024
@fatteneder
Copy link
Member

For me these tests pass locally and I am on linux + current master.

What version are you on? And is this on windows?

@IanButterworth
Copy link
Member Author

I'm on e07c0f1 on MacOS

@fatteneder
Copy link
Member

For me the tests also pass on that commit.
So maybe a MacOS issue?

@IanButterworth IanButterworth mentioned this issue Mar 29, 2024
Merged
IanButterworth added a commit that referenced this issue Mar 29, 2024
@IanButterworth
fix relocatable upgrades test (#53889)
09b356f 
Fixes #53885

Not the first time MacOS serving tempdir via a symlink has caused
obscure issues..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
packages Package management and loading
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix relocatable upgrades test IanButterworth/julia
2 participants
@IanButterworth @fatteneder