-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise an error when calling make with MARCHes known to fail #11656
Conversation
The only issue I can see is that some distro maintainers might want to support older architectures (and for cases it works reasonably well...). |
Yeah, this was discussed on the other issue. For Fedora, I'm supposed to make i386 or i686-compatible builds. But in practice, better a Pentium4 build than nothing, and I don't think anybody would notice. Shipping a build which doesn't pass the tests sounds like a very bad idea to me, especially if that's just to pretend supporting machines that nobody uses. |
Good enough for me. (I've also changed my ArchLinux julia-git package to pentium4 and claiming Just want to raise a concern I've seen from distro maintainers but if it has already been discussed I'll be totally find with it. |
Actually we build 32-bit binaries right now with
since there was a bug having to do with 32 bit calling convention in one of the dependencies, I think SuiteSparse. |
@tkelman Interesting. So |
I agree but if we're going to adjust the buildbot configuration we should carefully test all 32-bit platforms on both release-0.3 and master first, to make sure it doesn't bring back any bugs. |
@tkelman Sorry, I had missed your comment. I wasn't really suggesting to change the buildbots right now -- just to give both suggestions to the user. OK to merge the updated version? |
I don't think I've built successfully with |
OK, changed to |
I pushed a commit here to make sure this doesn't break 32 bit appveyor |
my mistake, sorry, I already covered this in julia/contrib/windows/msys_build.sh Line 49 in f3a6461
|
Pre-SSE2 CPUs are not supported as some tests fail (#7185). Better warn before the build.
Raise an error when calling make with MARCHes known to fail
Pre-SSE2 CPUs are not supported as some tests fail (#7185).
Better warn as soon as possible.