Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Parent argument for f(::Function) variants of mktemp{,dir} #12602

Merged
merged 2 commits into from Aug 15, 2015
Merged

RFC: Parent argument for f(::Function) variants of mktemp{,dir} #12602

merged 2 commits into from Aug 15, 2015

Conversation

ghost
Copy link

@ghost ghost commented Aug 13, 2015

This makes them on par with their non-f(::Function) equivalents. Most likely this functionality should have been included in f8ccca2.

"Bonus" commit: Documentation and mention in NEWS.md, I forgot to add this to #9017.

@ghost ghost changed the title Parent argument for f(::Function) variants of mktemp{,dir} RFC: Parent argument for f(::Function) variants of mktemp{,dir} Aug 13, 2015
@StefanKarpinski
Copy link
Member

👍

@tkelman
Copy link
Contributor

tkelman commented Aug 13, 2015

I think the docstrings need to go into both helpdb.jl, and (at least the signatures) into the RST where you have them. Running ./julia doc/genstdlib.jl should result in copying the docstring content from helpdb into the RST.

@ghost
Copy link
Author

ghost commented Aug 14, 2015

Thank you @tkelman, observant as always. I added the information to helpdb.jl as well, but I could not get doc/genstdlib.jl to inject the RST properly. Thus I added it manually to doc/stdlib/file.rst. If anyone can spot any syntax issue in what I wrote in doc/genstdlib.jl that could confuse the script, I would be most thankful. I think I am in line with the style used for other functions with more than one method.

@ghost
Copy link
Author

ghost commented Aug 15, 2015 via email

jakebolewski added a commit that referenced this pull request Aug 15, 2015
RFC: Parent argument for `f(::Function)` variants of `mktemp{,dir}`
@jakebolewski jakebolewski merged commit 3c915d3 into JuliaLang:master Aug 15, 2015
@ghost ghost deleted the nin/mktemp branch August 15, 2015 16:32
@tkelman
Copy link
Contributor

tkelman commented Aug 16, 2015

I'm not sure what was wrong - it may be that you need to run make clean && make before ./julia doc/genstdlib.jl works properly. The way you added it looks close enough, but when I rerun genstdlib it gets modified slightly - 8c0602e. I'll be merging that shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants