Preserve function attributes in prepare_call (plus clean up) #14084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
force-pushed
the
yyc/cleanup
branch
from
4f17191 to
add76fe
Compare
yuyichao
force-pushed
the
yyc/cleanup
branch
from
add76fe to
516d183
Compare
|
Ahhh..... I can never remember where to use |
|
Lgtm |
yuyichao
added a commit
that referenced
this pull request
Nov 21, 2015
Preserve function attributes in prepare_call (plus clean up)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the bug fix and clean up part of #14083 (which will probably take some time before it is ready...). Hopefully this can be merged earlier than #14083 and avoid some merge/rebase conflict