fix bug in issymmetric/ishermitian when zeros are stored #15504
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13645
I introduced a small bug in #11371 that made
issymmetric
give the wrong answer in some cases when the matrix had stored zeros.In short, the problem was that when I skipped storedzeros I have take into account that the
tracker
that keeps track of the next element needs to be incremented as well.I took the opportunity to add some comments to the code as well.
With:
We have:
On master:
On PR: