-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look for fesetround in libm rather than the executable #16291
Conversation
@@ -1,2 +1,2 @@ | |||
OPENLIBM_BRANCH=v0.4.1 | |||
OPENLIBM_SHA1=3ee2a6e6a9fc68cbf2ab00f830b9059215e40b06 | |||
OPENLIBM_SHA1=5fd9dcbbdf8565281c1b15f7cdc9d8594e70426a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a tag? delete the old checksums
we statically link libm into the executable on windows for this kind of thing |
Still, this is more correct and does no harm, so we should do it, no? |
Separately from a version change maybe. We should only be using a tagged version of openlibm, and Viral had a PR not that long ago that also upgraded openspecfun. Isn't some of the floating point environment controlled on a per shared library basis? Rearranging bootstrap to move the os dependent parts so much earlier is also a little unfortunate. |
@ViralBShah Can we tag a new openlibm version? It would be nice if windows build out of the box. |
We usually get lucky because GCC's runtime library includes this functions. However, their proper place is in the math library and Clang's runtime library does not include these functions on windows, so without this change the function is not found.
this isn't entirely true. on windows, iirc, it is usually provided as a statically linked file by the CRT. But my recollection was that we were actually providing this as an export from libjulia.dll and ./julia, due to our static linking to libopenlibm (which declares them DLLEXPORT). |
We usually get lucky because GCC's runtime library includes this functions.
However, their proper place is in the math library and Clang's runtime
library does not include these functions on windows, so without this change
the function is not found.
Also bump openlibm to include the latest changes that make openlibm
work with clang on windows.