Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TLS getter on windows #17183

Closed
wants to merge 1 commit into from
Closed

Fix TLS getter on windows #17183

wants to merge 1 commit into from

Conversation

yuyichao
Copy link
Contributor

  • Missing DllMain return value
  • Missing cast in jl_get_ptls_states

Ref 09a0be0#commitcomment-18054381

Use a PR mainly to make sure the return TRUE; in DllMain works...

@yuyichao
Fix TLS getter on windows
d1d67ed 
* Missing `DllMain` return value
* Missing cast in `jl_get_ptls_states`
@yuyichao yuyichao added system:windows Affects only Windows multithreading Base.Threads and related functionality labels Jun 29, 2016
@tkelman
Copy link
Contributor

tkelman commented Jun 29, 2016

maybe redundant with 558f44a?

@yuyichao
Copy link
Contributor Author

Yes.

@yuyichao yuyichao closed this Jun 29, 2016
@yuyichao yuyichao deleted the yyc/threads/win branch June 29, 2016 04:13
@yuyichao yuyichao mentioned this pull request Jul 1, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
multithreading Base.Threads and related functionality system:windows Affects only Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuyichao @tkelman