Improve promotion for constructors... #18623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by enabling `Type{}` specialization in the `promote_op` methods that request return information from Inference. Notably, this makes constructors behave in exactly the same manner as normal functions... even in cases where that behavior may be controversial:
```jl
julia> Int.(Number[1,2])
2-element Array{Number,1}:
1
2
julia> (x->Int(x)).(Number[1,2])
2-element Array{Number,1}:
1
2
```
|
Would you mind if I fix this together with #18622? Fixing the last one involves changing these functions too, so it would avoid some conflicts. |
|
Go for it. |
|
What would you think it would be better to return here |
nalimilan
reviewed
Sep 23, 2016
| @@ -337,3 +337,15 @@ end | |||
| @test broadcast(+, 1.0, (0, -2.0)) == (1.0,-1.0) | |||
| @test broadcast(+, 1.0, (0, -2.0), [1]) == [2.0, 0.0] | |||
| @test broadcast(*, ["Hello"], ", ", ["World"], "!") == ["Hello, World!"] | |||
|
|
|||
| # Ensure that even strange constructors that break `T(x)::T` work with broadcast | |||
There was a problem hiding this comment.
Do we actually care about such constructors? Is is supported to return an object not of type T? (I've been wondering about this for one of my packages.
|
Closed by #18642 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by enabling
Type{}specialization in thepromote_opmethods that request return information from Inference. Notably, this makes constructors behave in exactly the same manner as normal functions... even in cases where that behavior may be controversial: