Add case for Ubuntu 16.04

[TotalVerb]

This fixes #18693 for me.

fengyang@serval ~/julia> uname -a
Linux serval 4.4.0-47-generic #68-Ubuntu SMP Wed Oct 26 19:39:52 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

cc @tkelman

[tkelman]

Cool, thanks for testing. Only question I guess is if multiple of these are found, which should take priority?

[TotalVerb]

Are there distros with multiple path, and distinct certificate files? That seems like a difficult decision to make, if there are. But probably for now we can ignore it.

[staticfloat]

All distros I've seen where multiple of our paths match are symlinks to one concrete file. I've yet to see a system that has multiple certificate stores with different contents in them, and if one does exist, I'm not sure we can possibly know which is the best, unless we wanted to somehow test that the certificates work. (I don't think we want to do that)

[TotalVerb]

Is this good to merge then?

[tkelman]

We should verify that in an actual example, are these symlinks to the same file when multiple of them exist? If they're symlinks, does this copy them correctly (should it be dereferencing the symlink)?

[davidanthoff]

I just tested this on Bash on Ubuntu on Windows (or whatever the name is), and this fixes the bug there as well. This is using Ubuntu 14.04.

[TotalVerb]

Bump.

[staticfloat]

We should verify that in an actual example, are these symlinks to the same file when multiple of them exist? If they're symlinks, does this copy them correctly (should it be dereferencing the symlink)?

The only distribution I've been able to find that has both of these facts true is CentOS, which has OPENSSLDIR set to /etc/pki/tls, and both $(OPENSSL_DIR)/cert.pem and $(OPENSSL_DIR)/ca-bundle.crt available. (Note that ca-bundle.crt is not looked for by Julia, but is a second valid certificate store name).

Both of those certificate stores are symlinks to a third file, located at /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem. Julia correctly dereferences the symlink and copies the file contents into a normal file. Indeed, this is the same even on the CentOS 5.11 image that our binary builds are produced on.

[tkelman]

I've also seen Ubuntu installs that had multiple of these names present. Should look into whether they're all equivalent.

[staticfloat]

I looked around in docker installs of 14.04 and 16.04 and a live install of 14.04 and couldn't find any duplicate names, so I'm not sure what conditions need to be met for us to see that.

On Tue, Nov 29, 2016, 03:02 Tony Kelman ***@***.***> wrote: I've also seen Ubuntu installs that had multiple of these names present. Should look into whether they're all equivalent. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#19390 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAH_aGo47nnrUNRElz2LjXNK8X7smdHJks5rDAYxgaJpZM4K6NOC> .

--

…

-E

[staticfloat]

Thanks @TotalVerb for the contribution and @davidanthoff for the testing on Windows!