-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SparseArray._broadcast_type #19576
Conversation
Use `_promote_op` and `Broadcast.typestuple` instead of `Broadcast.ziptype` and `Broadcast.ftype`
CC @pabloferz |
Thanks. I thought there weren't more uses of I guess the |
Also, could you add a test so this does not go undetected again? |
Oh, it made the tests fail. I guess each PRs last test ran before the other one was merged, that's why it went undetected. (Yes, our current master fails tests.) |
I see. I wish there was a mechanism to avoid this kind of issue. |
https://github.com/servo/homu But IIRC it doesn't support AV which we need. |
I'll merge this even though it hasn't been open for long to avoid test failures the whole day. If this needs adjustments, it is better to do from a state where |
Bisection suggests that the first problematic commit is 02596f9 cc: @pabloferz |
For context to above. I previously had this comment here, but moved it to #19421 |
Thanks @martinholters! This change was a planned touchup to #19518, so LGTM. |
Use
_promote_op
andBroadcast.typestuple
instead ofBroadcast.ziptype
andBroadcast.ftype
.Broadcasting sparse matrices was rewritten to use
Broadcast.ziptype
andBroadcast.ftype
in 840820d, but those were removed in 02596f9.Fixes #19580