Clear out with/close/try/finally #20128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
force-pushed
the
ksh/nowithnoclose
branch
from
8be62a6 to
6df2c31
Compare
simonbyrne
reviewed
Jan 19, 2017
base/libgit2/signature.jl
Outdated
| @@ -15,15 +15,13 @@ function Signature(name::AbstractString, email::AbstractString) | |||
| @check ccall((:git_signature_now, :libgit2), Cint, | |||
| (Ptr{Ptr{SignatureStruct}}, Cstring, Cstring), sig_ptr_ptr, name, email) | |||
| sig = GitSignature(sig_ptr_ptr[]) | |||
| s = Signature(sig.ptr) | |||
| close(sig) | |||
| s = Signature(sig.ptr) | |||
There was a problem hiding this comment.
return Signature(sig.ptr) ?
|
Fine with me. I'm happy to continue to do style cleanup on this PR while we wait. |
kshyatt
force-pushed
the
ksh/nowithnoclose
branch
from
6df2c31 to
7ccde63
Compare
tkelman
reviewed
Jan 20, 2017
base/libgit2/libgit2.jl
Outdated
| if isa(err, GitError) | ||
| throw(GitError(Error.Object, err.Code, "cannot create branch `$branch_name` with `$commit_id`")) | ||
| else | ||
| rethrow(e) |
kshyatt
force-pushed
the
ksh/nowithnoclose
branch
from
7ccde63 to
f526c04
Compare
|
Looks like some files under |
kshyatt
force-pushed
the
ksh/nowithnoclose
branch
2 times, most recently
from
9ee6603 to
de93d3b
Compare
|
Is the arrayops thing to do with me? |
kshyatt
force-pushed
the
ksh/nowithnoclose
branch
2 times, most recently
from
15c83b8 to
a61e579
Compare
|
Likely. That happens if you try to delete a file that you still have open handles to. |
|
It seems to be failing on |
kshyatt
force-pushed
the
ksh/nowithnoclose
branch
from
a61e579 to
0315300
Compare
kshyatt
force-pushed
the
ksh/nowithnoclose
branch
from
0315300 to
bca780c
Compare
Replaced some `close` calls with explicit `free` on pointers.
kshyatt
force-pushed
the
ksh/nowithnoclose
branch
from
bca780c to
a7b25a7
Compare
|
This is hella old and conflicted so I'm going to close (ironic, I know) and try again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced some
closecalls with explicitfreeon pointers.I did a little bit of whitespace prettying as well.