Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing GC root #20917

Merged
merged 1 commit into from
Mar 7, 2017
Merged

Fix missing GC root #20917

merged 1 commit into from
Mar 7, 2017

Conversation

Keno
Copy link
Member

@Keno Keno commented Mar 6, 2017

Type intersection can return a new type and jl_subtype can allocate,
so this value needs to be rooted.

@Keno
Fix missing GC root
df62c99 
Type intersection can return a new type and jl_subtype can allocate,
so this value needs to be rooted.
@ararslan ararslan added the GC Garbage collector label Mar 6, 2017
@StefanKarpinski
Copy link
Member

Found with ClangSA?

@Keno
Copy link
Member Author

Keno commented Mar 6, 2017

yes

@vtjnash vtjnash merged commit 8dc7064 into master Mar 7, 2017
@vtjnash vtjnash deleted the kf/nextgcroot branch March 7, 2017 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuyichao yuyichao yuyichao approved these changes

Assignees
No one assigned
Labels
GC Garbage collector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Keno @StefanKarpinski @yuyichao @vtjnash @ararslan