Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually test solving ModInt example with lufact #22191

Merged
merged 1 commit into from
Jun 5, 2017
Merged

Actually test solving ModInt example with lufact #22191

merged 1 commit into from
Jun 5, 2017

Conversation

fredrikekre
Copy link
Member

Fix the test for #22146
ref #22146 (comment)

Sacha0
Sacha0 approved these changes Jun 2, 2017
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :)

@Sacha0
Copy link
Member

Sacha0 commented Jun 4, 2017

The CI failures appear unrelated. Absent objections, requests for time, or someone beating me to it, I plan to merge this tomorrow morning. Best!

@Sacha0 Sacha0 merged commit 8e4202a into JuliaLang:master Jun 5, 2017
@Sacha0 Sacha0 added linear algebra Linear algebra test This change adds or pertains to unit tests labels Jun 5, 2017
@arghhhh
Copy link
Contributor

arghhhh commented Jun 5, 2017

A better test now is making the matrix A such that istriu(A)==false and istril(A)==false so that A\b goes into lufact. Then you don't need the second test at all - I think.
eg. A = [ModInt{2}(0) ModInt{2}(1) ; ModInt{2}(1) ModInt{2}(0)]

@fredrikekre fredrikekre deleted the fe/lu-testfix branch June 5, 2017 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sacha0 Sacha0 Sacha0 approved these changes

Assignees
No one assigned
Labels
linear algebra Linear algebra test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredrikekre @Sacha0 @arghhhh