-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate syntax 1.+
. fixes #19089
#22459
Conversation
4df4c25
to
0946a6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (modulo the parser changes which I did not pore over)! :)
Might be worth mentioning the need for disambiguation in the documentation somewhere? |
Added a bit on this to the manual. |
0946a6f
to
4e91e73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for the manual addition! :)
Was there any argument for why keeping the I find that putting spaces for operations like division, multiplication and exponentiation to be fairly jarring as it makes their higher precedence less obvious. I also think more people use the syntax
|
I see numeric literal syntax as much more established than dot operator syntax. Even if |
Remove the `.` in `1./(...)` where it was meant to make `1.` a float but was actually parsed as `1 ./ (...)` and now gives a deprecation warning due to JuliaLang/julia#22459.
No description provided.