update code and tests to limit false sharing and unnecessary creation of globals #23631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it seems a great piece of work. |
vtjnash
force-pushed
the
jn/toplevel-scope-tests
branch
from
228c554 to
a30c4c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not intended to change the functionality being tested, just reduce the number of globals left around afterwards. Thus, it's not NFC, but it should be reasonably close. Since this resulted in a lot of indentation changes, the
?w=1diff is a bit smaller, although still pretty large. Since this does need to hit quite a few files, I expect I'll eventually need to try to merge this fairly quickly.Ref #19324, as this is rebased from that PR based on Stefan's suggestion of #19324 (comment)