-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
there is a full, its name is widen #24148
Conversation
I don't quite think this name fits.
Am I correct in the fact that the defining characteristic of this operation is that we want to ensure that the returned array is completely mutable? Or maybe both dense and completely mutable? If either of those are case, then I think I'd prefer to defer the design here to the broader trait scheme discussion for 1.x. I'm not entirely sure what the answer will be, but it'd be nice to leave the door open here. I think that means not giving this operation a name for now. |
Neither of those is the case :). The semantics of this operation are: Given a wrapped array type (the "narrower" type), return the type of the parent of a The name does not matter to me :). (The analogy is quite loose, but the type / instance behavior is roughly the same: widen the type, convert instances to the widened type of that instance.)
As I express in #24147, I share those sentiments:
Best! |
I also think |
Closing in favor of #24147. Thanks all! |
This pull request sketches the second option described in #24147 / provides the functionality discussed in #23270. (After some thought, that generic function has (in an abstract sense) the semantics of
widen
. So for now this pull request extendswiden
instead of introducing a new exported name.) Please see #24147 for more. Best!