Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix FFTW deprecation #24540

Merged
merged 1 commit into from
Nov 10, 2017
Merged

fix FFTW deprecation #24540

merged 1 commit into from
Nov 10, 2017

Conversation

stevengj
Copy link
Member

@stevengj stevengj commented Nov 8, 2017

This fixes #24532: there was a missing deprecation for the Base.FFTW module itself that prevented FFTW.jl symbols from being imported into a module.

@stevengj stevengj added the deprecation This change introduces or involves a deprecation label Nov 8, 2017
@stevengj stevengj requested a review from ararslan November 8, 2017 21:20
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Great catch!

@stevengj
Copy link
Member Author

stevengj commented Nov 9, 2017

CI failures seem unrelated.

@mauro3
Copy link
Contributor

mauro3 commented Nov 10, 2017

Backport?

@ararslan
Copy link
Member

FFTW is not deprecated in 0.6.

@ararslan ararslan merged commit 2e4ef81 into JuliaLang:master Nov 10, 2017
@stevengj stevengj deleted the fftw-deprecation branch November 10, 2017 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation This change introduces or involves a deprecation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecated_moved not working properly inside modules
4 participants