Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove reload #25207

Merged
merged 1 commit into from
Dec 21, 2017
Merged

remove reload #25207

merged 1 commit into from
Dec 21, 2017

Conversation

StefanKarpinski
Copy link
Member

@StefanKarpinski StefanKarpinski commented Dec 20, 2017

Send reload the way of the dodo – and workspace. Now that Revise is the way to do this sort of thing, perhaps we should get rid of reload as well. Both require and reload are soon going to need to pass in a context module in order to determine what the meaning of the name argument means, so this is going to have to change API in any case. See also #25046, #25166.

Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL there is (was) a function called reload

@StefanKarpinski StefanKarpinski added the triage This should be discussed on a triage call label Dec 20, 2017
@vchuravy vchuravy merged commit d24ccd4 into master Dec 21, 2017
@vchuravy
Copy link
Member

vchuravy commented Dec 21, 2017

(Didn't see the triage label before merging, mea culpa)

@JeffBezanson JeffBezanson removed the triage This should be discussed on a triage call label Dec 21, 2017
@StefanKarpinski StefanKarpinski deleted the sk/xreload branch December 21, 2017 15:08
@vtjnash
Copy link
Member

vtjnash commented Dec 21, 2017

reload is still very helpful for cases where Revise won't work

@rdeits
Copy link
Contributor

rdeits commented Dec 21, 2017

I actually use reload almost daily, precisely for the situations where Revise doesn't work (for example, when I change a type definition). Restarting Julia instead is ok, but can involve waiting minutes for things like Plots to compile (I realize that there's a ton of work underway to make this situation better in the future).

What is the suggested workflow when developing a new module and modifying the types in that module? Should I just include() the module file instead of using reload? Or just restart Julia?

@StefanKarpinski
Copy link
Member Author

StefanKarpinski commented Dec 21, 2017

I can look at adding this back after I've done my code loading changes, but it's going to need a different API because a name can no longer unambiguously determine a module. You need at least the module from which reload is being loaded. In short, the previous reload cannot be done.

@rdeits
Copy link
Contributor

rdeits commented Dec 21, 2017

That makes sense. I'd have no issue calling some other function with a more precise argument than just the module name as long as there's some way to reload a module without restarting Julia. Thanks for all your work on this!

@StefanKarpinski
Copy link
Member Author

It may be possible for the API to be reload(Foo) where Foo is the actual module object.

@rdeits
Copy link
Contributor

rdeits commented Dec 21, 2017

That would be absolutely perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants