-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove reload #25207
remove reload #25207
Conversation
7945a78
to
23362c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL there is (was) a function called reload
(Didn't see the triage label before merging, mea culpa) |
|
I actually use What is the suggested workflow when developing a new module and modifying the types in that module? Should I just |
I can look at adding this back after I've done my code loading changes, but it's going to need a different API because a name can no longer unambiguously determine a module. You need at least the module from which |
That makes sense. I'd have no issue calling some other function with a more precise argument than just the module name as long as there's some way to reload a module without restarting Julia. Thanks for all your work on this! |
It may be possible for the API to be |
That would be absolutely perfect. |
Send
reload
the way of the dodo – andworkspace
. Now that Revise is the way to do this sort of thing, perhaps we should get rid ofreload
as well. Bothrequire
andreload
are soon going to need to pass in a context module in order to determine what the meaning of thename
argument means, so this is going to have to change API in any case. See also #25046, #25166.